-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update volcengine model #1586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zhourunlai! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!
5a7b5c5
to
31256b1
Compare
I beleive this will need the necessary URL and request changes in models.ts, types.ts, generation.ts, et cetera. Unless that's on another PR then these changes won't work as intended. |
Volcengine is compatible with openai’s API, so this can work in generateText |
31256b1
to
e9a0db0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me given the docs link clarifying that volcengine is compatible with OpenAI. Link here: https://www.volcengine.com/docs/82379/1330626
feat: update volcengine model
Relates to:
Risks
Background
What does this PR do?
update volcengine large model and add model settings, doc: https://www.volcengine.com/docs/82379/1330310
What kind of change is this?
Improvements
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps